[BUG] PortalRedirect

[OhReally]

Hi Dennis,

Just installed PortalRedirect, thanks for that.

It has one small bug: change the cookie name in line 118 to $_COOKIE["{$mybb->settings['cookieprefix']}viewedportal"] or people will never be able to escape from the portal at a forum with a custom cookie prefix.

Cheers,
Rob

---

More thoughts on this...

People not accepting cookies will never be able to escape from the portal page.

Would it be possible to
A) add this to the session in stead of a cookie?
or B) not redirect visitors who don't accept cookies?

Cheers,
Rob

[DennisTT]

Thanks for reporting. I'll fix it shortly.

MyBB requires users to have cookies to be able to login. I think the only way to check if the user has a cookie is something like...

user arrives at index.php - set TEST cookie, redirect to index.php?action=checkcookie
user arrives at index.php?action=checkcookie - if TEST cookie is seen, check viewedportal cookie and either redirect to portal.php or show full index.php

[OhReally]

(08-30-2008 03:45 AM)DennisTT Wrote:  MyBB requires users to have cookies to be able to login.

Ah, ok. Didn't check that, sorry. That invalidates my second point...

(08-30-2008 03:45 AM)DennisTT Wrote:  I think the only way to check if the user has a cookie is something like...

user arrives at index.php - set TEST cookie, redirect to index.php?action=checkcookie
user arrives at index.php?action=checkcookie - if TEST cookie is seen, check viewedportal cookie and either redirect to portal.php or show full index.php

Sounds like what I was thinking. And of course TEST cookie would only have to be set if none of the other cookies (viewedportal, mybbuser, etc.) is found, which could save quite some redirects to index.php?action=checkcookie.

But isn't there a cookie test in the core code, already? I can imagine that, if you need to accept cookies to be able to login, there is a warning message somewhere which is displayed to users not accepting cookies, explaining them why they can't log in...